cor3ntin added inline comments.
================ Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); ---------------- Fznamznon wrote: > cor3ntin wrote: > > Maybe we should do that now, by passing `TemplateArgs` to computeDependence? > > > > Otherwise there is a good chance that fixme never gets fixed ! > `computeDependence` is called by the constructor of `MemberExpr` which > doesn't accept template augments. In order to do that, I would need to modify > the constructor of `MemberExpr`. > Is it still reasonable to do as a part of this fix? Oh, i missed that the fixme is pre-existing, NVM then, i think you can leave it as-is. Sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits