hokein added a comment. In D153296#4480141 <https://reviews.llvm.org/D153296#4480141>, @yronglin wrote:
> In D153296#4479718 <https://reviews.llvm.org/D153296#4479718>, @hokein wrote: > >> Thanks, this looks good. > > Thanks for your review! I don't know why the reversion status still `Needs > Review`, and the `libcxx ci` often fails to start. I guess the `Needs Review` is probably caused by the previous "Requested Changes" by Aaron. The `libcxx ci` failure doesn't seem to be relevant. I think we're all on the same page about the fix, it is fine to land it assuming that the `ninja check-clang` passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
