MaskRay added a comment.

In D154357#4487896 <https://reviews.llvm.org/D154357#4487896>, @cwalther wrote:

> Thanks for the comments. Yes, `powerpc-*-eabi` should be valid (sorry if I 
> was unclear about that – my parenthetical was only about AArch64). There is a 
> PowerPC EABI: https://www.nxp.com/docs/en/application-note/PPCEABI.pdf . I 
> wouldn’t know if Clang/LLD obey it, but it works for us…
>
> I am fine with removing the vendor check if that is the consensus.

Sounds good. I think `&&` is cleaner: `return Triple.getOS() == 
llvm::Triple::UnknownOS && ...`;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154357/new/

https://reviews.llvm.org/D154357

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to