phosek added a comment. In D153989#4494012 <https://reviews.llvm.org/D153989#4494012>, @nathanchance wrote:
> This change appears to break `-DCOMPILER_RT_BUILD_CRT=OFF`: > > $ cmake -B build -S llvm -DCMAKE_BUILD_TYPE=Release > -DCOMPILER_RT_BUILD_CRT=OFF -DLLVM_ENABLE_PROJECTS='clang;compiler-rt;lld' > ... > CMake Error at cmake/modules/AddLLVM.cmake:1935 (add_dependencies): > The dependency target "crt" of target "check-all" does not exist. > Call Stack (most recent call first): > cmake/modules/AddLLVM.cmake:1975 (add_lit_target) > CMakeLists.txt:1211 (umbrella_lit_testsuite_end) > > > CMake Error at cmake/modules/AddLLVM.cmake:1935 (add_dependencies): > The dependency target "crt" of target "check-compiler-rt" does not exist. > Call Stack (most recent call first): > cmake/modules/AddLLVM.cmake:1975 (add_lit_target) > /home/nathan/cbl/src/llvm-project/compiler-rt/test/CMakeLists.txt:114 > (umbrella_lit_testsuite_end) > > > CMake Error at cmake/modules/AddLLVM.cmake:1935 (add_dependencies): > The dependency target "crt" of target "check-builtins" does not exist. > Call Stack (most recent call first): > cmake/modules/AddLLVM.cmake:2001 (add_lit_target) > > /home/nathan/cbl/src/llvm-project/compiler-rt/test/builtins/CMakeLists.txt:112 > (add_lit_testsuite) > ... Thanks for this heads up, this should be addressed in rG926f3759ec62a8f170e76a60316cc0bdd9dd2ec9 <https://reviews.llvm.org/rG926f3759ec62a8f170e76a60316cc0bdd9dd2ec9>. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
