ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land.
Looks great! ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:609 + StorageLocation &createObjectInternal(const VarDecl *D, QualType Ty, + const Expr *InitExpr); ---------------- At least document the nullability of D and InitExpr? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155075/new/ https://reviews.llvm.org/D155075 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
