ahatanak added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:89
+ // Don't reject these -version-min= if we have the appropriate triple.
if (T.isiOS())
for (Arg *A : Args.filtered(options::OPT_mios_version_min_EQ))
----------------
I just realized this isn't correct as it accepts `-mios-version-min=` when the
OS is tvOS, e.g., `clang -arch armv7m --target=thumbv7-apple-tvos
-mios-version-min=5 ...`.
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/TargetParser/Triple.h#L497
Can you fix this by calling `Triple::getOS()` to check the OS?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155408/new/
https://reviews.llvm.org/D155408
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
