t-rasmud accepted this revision. t-rasmud added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are neither warned nor reachable from a warned one. + for (auto I = FixablesForAllVars.byVar.begin(); ---------------- Nit: Maybe also mention when a variable is neither warned nor is reachable? Are there scenarios besides variables inside pragmas where this constraint is satisfied? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
