aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM as far as the changes go, but did have a question about whether we need
this for unsigned values as well.
================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:36
+/// Pushes \p Val to the stack, as a target-dependent 'int'.
+static void pushInt(InterpState &S, int32_t Val) {
+ const TargetInfo &TI = S.getCtx().getTargetInfo();
----------------
Do we need the same for unsigned int as well? (I'm thinking in terms of pushing
literal values like `0U`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155568/new/
https://reviews.llvm.org/D155568
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
