rjmccall added inline comments.
================ Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 + if (auto *G = dyn_cast<GCCAsmStmt>(Jump)) { + for (AddrLabelExpr *L : G->labels()) { ---------------- I think it would be good to leave a comment here like this: > We know the possible destinations of an asm goto, but we don't have the > ability to add code along those control flow edges, so we have to diagnose > jumps both in and out of scopes, just like we do with an indirect goto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits