PiotrZSL added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.cpp:91-102 + Finder->addMatcher( + fieldDecl(unless(isMemberOfLambda()), + hasDeclContext(cxxRecordDecl(isCopyableOrMovable())), + hasType(hasCanonicalType(referenceType()))) + .bind("ref"), + this); + Finder->addMatcher( ---------------- carlosgalvezp wrote: > PiotrZSL wrote: > > Check first type, should be cheaper and consider mering those two. > Thanks for the tip! I'm not familiar with having multiple binds in the same > `addMatcher` call. Do I still need to keep the `bind("ref")` at the end? No, bind at the end need to be removed (I forgot about that). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155625/new/ https://reviews.llvm.org/D155625 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits