philnik added inline comments.
================
Comment at: clang/include/clang/AST/DeclCXX.h:1269
/// Determine whether this class has a non-trivial copy constructor
/// (C++ [class.copy]p6, C++11 [class.copy]p12)
bool hasNonTrivialCopyConstructor() const {
----------------
royjacobson wrote:
> shafik wrote:
> > These references looks like they need to be updated. Same below and it
> > looks like `hasNonTrivialCopyConstructorForCall` is missing references all
> > together.
> TBH I don't think those functions actually need references to the standard?
> Whether the actual member functions are trivial or not is already calculated
> before. Do you think I can just remove it? :)
I think it makes sense to call out that these functions represent something
from the standard. There are other functions with similar names, which don't
have an equivalent in the C++ standard, like `hasTrivialDestructorForCall`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154893/new/
https://reviews.llvm.org/D154893
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
