hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks, looks good to me.
================
Comment at: clang/test/AST/ast-dump-recovery.m:24
+// CHECK-NEXT: | `-BlockDecl {{.*}} invalid
+int (^a)() = ^() {
+ return c;
----------------
nit: it'd be nice to encode the github issue number to the testcase here, for
example (renaming the `a` to `gh63863` etc).
================
Comment at: clang/test/AST/ast-dump-recovery.m:25
+int (^a)() = ^() {
+ return c;
+};
----------------
nit: use a more descriptive name `return undef;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155396/new/
https://reviews.llvm.org/D155396
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
