ymandel added inline comments.
================ Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:101-103 +/// groups topologically. As a result, the blocks in a series of loops are +/// ordered such that all nodes in loop `i` are earlier in the order than nodes +/// in loop `j`. This ordering, when combined with widening, bounds the number ---------------- xazax.hun wrote: > ymandel wrote: > > xazax.hun wrote: > > > I wonder if we still want to somehow enforce that within a loop/interval > > > the we visit nodes in the RPO order. > > Starting with RPO should make this algorithm cheaper (and maybe simpler!). > > But, RPO construction isn't free. So, I think it is a matter of cost -- > > compare generating the RPO first and then using that here vs. just using > > this directly. I can put a note in the implementation as FIXME. WDYT? > Sounds good to me. Added a FIXME in `buildIntervals`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
