aaron.ballman added reviewers: efriedma, rjmccall, erichkeane.
aaron.ballman added a comment.

Adding additional reviewers for more opinions.

The changes seem reasonable to me given that the annotation attribute is used 
to squirrel data from the frontend to the backend (including via plugin 
attributes) and so its usage is pretty general. But I'd like a second opinion 
given that this attribute has only passed data along for function definitions 
for a *long* time. I'm not certain if changing this will cause surprises for 
the backend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156172/new/

https://reviews.llvm.org/D156172

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to