tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Boolean.h:113
+ static Boolean bitcastFromMemory(const std::byte *Buff) {
+ bool Val = static_cast<bool>(*Buff);
+ return Boolean(Val);
----------------
MitalAshok wrote:
> Does this handle padding bits correctly? E.g., `__builtin_bit_cast(bool,
> (unsigned char) 0b10u)` should be false
No, it doesn't. But clang has a completely different opinion about that test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154951/new/
https://reviews.llvm.org/D154951
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
