Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment.
I think will be good idea to add cases when member is initialized in declaration and constructor, with same and different values. ================ Comment at: docs/clang-tidy/checks/readability-redundant-member-init.rst:4 @@ +3,3 @@ +readability-redundant-member-init +================================== + ---------------- This line length should be same as header above. ================ Comment at: docs/clang-tidy/checks/readability-redundant-member-init.rst:13 @@ +12,3 @@ + // Explicitly initializing the member s is unnecessary. + class Foo { + public: ---------------- Please run Clang-format over example. Will be good idea to add empty line before private. ================ Comment at: test/clang-tidy/readability-redundant-member-init.cpp:33 @@ +32,3 @@ + + +struct NF1 { ---------------- Please remove extra empty-line. Repository: rL LLVM https://reviews.llvm.org/D24339 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits