v.g.vassilev added a comment.
Thanks for working on this!
On my browser the note "Detected code clone" note appears slightly off the
highlighted range which was a bit confusing to me.
Given my limited understanding of the SA bug reports, this looks good to me.
================
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:83
@@ +82,3 @@
+static PathDiagnosticLocation makeLocation(const StmtSequence &S,
+ AnalysisManager &Mgr) {
+ ASTContext &ACtx = Mgr.getASTContext();
----------------
Probably an indent here would make this look more consistent.
================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:348
@@ +347,3 @@
+
+
+bool AnalyzerOptions::shouldDisplayExtraNotesAsEvents() {
----------------
Extra new line?
https://reviews.llvm.org/D24278
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
