MaskRay accepted this revision.
MaskRay added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:155
+def offload_Group : OptionGroup<"<offload group>">, Group<f_Group>,
+                   DocName<"Common Offloading flags">;
+
----------------
The existing `flags` uses are misnomer (`Flag` does not accept values). Perhaps 
use `options` for new option groups.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156886/new/

https://reviews.llvm.org/D156886

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to