dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land.
Thanks. Looks good. You may need to rebase over new tests, make sure everything is still passing when you do. LGTM ================ Comment at: llvm/test/CodeGen/AArch64/misched-detail-resource-booking-01.mir:1 +# NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 # RUN: llc -mtriple=aarch64-none-linux-gnu -mattr=+neon %s -o - 2>&1 \ ---------------- harviniriawan wrote: > dmgreen wrote: > > This doesn't look right. Should it be using -mcpu=cortex-a55 instead? > shouldn't it be a510 as it's the default scheduling policy now? Sorry I forgot to reply to the old comment. AFAIU this is testing some of the info in the scheduling model, not which model is being used. So pinning it to the A55 makes sense for keeping the old testing in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156799/new/ https://reviews.llvm.org/D156799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
