aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some minor tweaks (some extra parens to remove, a spurious 
comment to remove).



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4359
+      llvm::find_if(Result, [this](const NamedDecl *Elem) {
+        return (isa<FieldDecl, IndirectFieldDecl>(Elem)) &&
+               Elem->isPlaceholderVar(getLangOpts());
----------------



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4370
+      break;
+    if ((isa<FieldDecl, IndirectFieldDecl>(ND)) &&
+        ND->isPlaceholderVar(getLangOpts()))
----------------



================
Comment at: clang/test/SemaCXX/cxx2c-placeholder-vars.cpp:1-2
+///////////////
+// RUN: %clang -cc1 -fsyntax-only -verify -std=c++2c -Wunused-parameter 
-Wunused -Wpre-c++26-compat %s
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153536/new/

https://reviews.llvm.org/D153536

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to