jhuber6 added inline comments.
================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:36
-// The implicit arguments of AMDGPU kernels.
-struct AMDGPUImplicitArgsTy {
- uint64_t OffsetX;
- uint64_t OffsetY;
- uint64_t OffsetZ;
- uint64_t HostcallPtr;
- uint64_t Unused0;
- uint64_t Unused1;
- uint64_t Unused2;
+enum IMPLICITARGS : uint32_t {
+ COV4_SIZE = 56,
----------------
arsenm wrote:
> This is getting duplicated a few places, should it move to a support header?
>
> I don't love the existing APIs for this, I think a struct definition makes
> more sense
The other user here is my custom loader, @JonChesterfield has talked about
wanting a common HSA helper header for awhile now.
I agree that the struct definition is much better. Being able to simply
allocate this size and then zero fill it is much cleaner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139730/new/
https://reviews.llvm.org/D139730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
