sdesmalen added inline comments.
================
Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181
+void non_za_definition(void) {
+ sme_arm_new_za(); // OK
----------------
rsandifo-arm wrote:
> Would be good to have some tests for indirect function calls too (via
> function pointers), to make sure that the diagnostic still works when no decl
> is available.
>
> I suppose this applies to D157269 too.
I'm not sure that's necessary because D127762 already added tests to ensure the
attributes propagate on pointer types, which then sets the ExtProtoInfo for
those values. This patch merely checks the SME attribute fields from
ExtProtoInfo. i.e. there is already nothing depending on a declaration being
available.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157270/new/
https://reviews.llvm.org/D157270
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
