nickdesaulniers added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402 + return nullptr; + } + ---------------- A lot of these visitor methods for UnaryOperator are going to look almost the same; I think I might prefer to have a `VisitUnaryOperator` method instead, and simply switch on the kind of operator. But perhaps, I should flush out more of these methods, then do such refactoring? WDYT @efriedma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157432/new/ https://reviews.llvm.org/D157432 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
