On 11 September 2016 at 21:14, Sam Shepperd via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> phabricss added a subscriber: phabricss. > phabricss added a comment. > > It is still impossible to compile glibc with clang due to this bug. Could > this patch be reviewed please. > Firstly, I thought glibc had applied a patch to fix this bug? As in, the error is correct and glibc fixed their bug? As for the patch, its goal is to only demote an error to warning when the function with conflicting asm labels is never used. That's pretty clearly a workaround (if you ever call acoshl, then you'll get an error), but moreover the check is implemented incorrectly. "New->isUsed()" will be performed at the moment the new declaration is being parsed; of course it hasn't been used yet. isUsed() will turn true only after it's used, after we actually parse the rest of the code and build AST for the uses of the new declaration. As I suggested in my last review comment, you would need to defer the check until ActOnEndOfTranslationUnit in order to correctly answer New->isUsed(). Or just not try to implement this workaround, and instead change how codegen works so that we emit calls to functions with the same asm label that gcc would choose. https://reviews.llvm.org/D16171 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits