hazohelet accepted this revision.
hazohelet added a comment.
I think it would be helpful to point to the subobject source range when
diagnosing errors in subobject dtors, so I left some suggestions.
Otherwise this LGTM. Thanks!
================
Comment at: clang/lib/AST/ExprConstant.cpp:6663
APValue *SubobjectValue = &Value.getStructField(FD->getFieldIndex());
- if (!HandleDestructionImpl(Info, CallLoc, Subobject, *SubobjectValue,
+ if (!HandleDestructionImpl(Info, CallRange, Subobject, *SubobjectValue,
FD->getType()))
----------------
================
Comment at: clang/lib/AST/ExprConstant.cpp:6682
APValue *SubobjectValue = &Value.getStructBase(BasesLeft);
- if (!HandleDestructionImpl(Info, CallLoc, Subobject, *SubobjectValue,
+ if (!HandleDestructionImpl(Info, CallRange, Subobject, *SubobjectValue,
BaseType))
----------------
It's not the problem of this patch, but it might be nice to have
`CXXBaseSpecifier::getTypeSourceRange` or alike because this is an interesting
source range.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156604/new/
https://reviews.llvm.org/D156604
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
