capfredf added inline comments.

================
Comment at: clang/include/clang/Frontend/ASTUnit.h:901
+                    SmallVectorImpl<const llvm::MemoryBuffer *> &OwnedBuffers,
+                    std::function<void(CompilerInstance&)> 
AfterBeginSourceFile = [](CompilerInstance& CI) -> void {});
 
----------------
@v.g.vassilev  Not sure if this is the right solution or idiom to extend this 
method.  

we can make this high order function more general, like 
`std::unique_ptr<SyntaxOnlyAction*><()>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154382/new/

https://reviews.llvm.org/D154382

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to