hubert.reinterpretcast added a comment. In D155610#4586213 <https://reviews.llvm.org/D155610#4586213>, @abhina.sreeskantharajan wrote:
> I've discussed offline with @hubert.reinterpretcast and agree with him that > with the addition of fexec-charset support, the set of characters deemed > printable will not be accurate when other encodings are used. This will be > similar to the printf/scanf format string validation issue I mentioned in my > RFC and would require us to reverse the conversion or keep the original > string around to check if the character is printable. I don't think we have > finalized a solution on how to handle these issues yet. Furthermore, it is reasonable for the scope of the current patch to focus on producing UTF-8 (or UTF-16 for Windows) output to the "terminal". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
