aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some minor concerns. In D153156#4507440 <https://reviews.llvm.org/D153156#4507440>, @rZhBoYao wrote: > There seems to be no clear objection to this and > https://reviews.llvm.org/D152632 and the CI are passing for both. Any chance > that I merge these two before llvm 17 branch out (IIRC the next Monday)? As this isn't fixing a regression, I think it'd be better to let it bake a while longer in Clang 18 (unless there's some extenuating circumstances where we need to land this sooner). ================ Comment at: clang/test/SemaCXX/reserved-identifier.cpp:91-92 long double sangbleu = operator""_SacreBleu(1.2); // no-warning -void operator"" _lowercase(unsigned long long); // no-warning +void operator""_lowercase(unsigned long long); // no-warning void operator""_lowercase(unsigned long long); // no-warning ---------------- No need to have a duplicate test. ================ Comment at: clang/www/cxx_dr_status.html:8648 <td>Syntax of <I>literal-operator-id</I></td> - <td class="none" align="center">Unknown</td> + <td class="unreleased" align="center">Clang 17</td> </tr> ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits