hvdijk added a comment.

In D86310#4596932 <https://reviews.llvm.org/D86310#4596932>, @tmgross wrote:

> Was your failure in https://bugs.llvm.org/show_bug.cgi?id=50198 fixed with 
> these patches?

Yes, it was (at least it was at the time that I initially commented).

> I cannot reproduce that failure for some reason, but it would likely make a 
> good run-pass test.

It's reproducible online, https://godbolt.org/z/j918EeoMv, it would be 
interesting to know why it does not fail for you.

> These two patches do not seem to fix varargs segfaulting, as documented in 
> https://bugs.llvm.org/show_bug.cgi?id=19909 (testing with this code 
> https://godbolt.org/z/WeE7TvrGe) so it seems like that will need a separate 
> fix.

Thanks, and clang appears to avoid the use of the LLVM `va_arg` instruction 
here; we'll have to make sure to adapt that example to the LLVM IR equivalent 
that does use `va_arg` to make sure that's tested as well, and fixed if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86310/new/

https://reviews.llvm.org/D86310

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to