JonChesterfield added a comment.
The lowering pass is broadly right, missing a few edge cases.
================
Comment at: libc/config/gpu/entrypoints.txt:88
+ libc.src.stdio.vsnprintf
libc.src.stdio.puts
libc.src.stdio.fopen
----------------
^these try to build, but fail. I haven't managed to debug the libc cmake to
work out what I'm missing
================
Comment at: libc/test/src/__support/CMakeLists.txt:62
-# The GPU does not support varargs currently.
-if(NOT LIBC_TARGET_ARCHITECTURE_IS_GPU)
- add_libc_test(
- arg_list_test
- SUITE
- libc-support-tests
- SRCS
- arg_list_test.cpp
- DEPENDS
- libc.src.__support.arg_list
- )
-endif()
+add_libc_test(
+ arg_list_test
----------------
this one builds and passes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158246/new/
https://reviews.llvm.org/D158246
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
