thakis created this revision. thakis added a reviewer: aganea. Herald added a project: All. thakis requested review of this revision.
As far as I can tell, there's nothing Windows-specific about the test and it passes fine on other platforms. I found this test when running rg clang_cl clang/test | rg '%s' | rg -v -- ' -- ' | rg -v not after 547ee1c81fceaabcb <https://reviews.llvm.org/rG547ee1c81fceaabcb7064ed525f11f9e94083f56> to see if other tests were missing `--` before `%s` in `%clang_cl` invocations. This was the only one. Since it used to run only on Windows, it wasn't needed, but as far as I can tell there's no reason to run it only on Windows. https://reviews.llvm.org/D158279 Files: clang/test/Frontend/rewrite-includes-macros.cpp Index: clang/test/Frontend/rewrite-includes-macros.cpp =================================================================== --- clang/test/Frontend/rewrite-includes-macros.cpp +++ clang/test/Frontend/rewrite-includes-macros.cpp @@ -1,7 +1,8 @@ -// REQUIRES: system-windows -// RUN: %clang_cl /E -Xclang -frewrite-includes %s | %clang_cl /c -Xclang -verify /Tp - +// RUN: %clang_cl /E -Xclang -frewrite-includes -- %s | %clang_cl /c -Xclang -verify /Tp - // expected-no-diagnostics +// This test uses dos-style \r\n line endings. +// Make sure your editor doesn't rewrite them to unix-style \n line endings. int foo(); int bar(); #define HELLO \
Index: clang/test/Frontend/rewrite-includes-macros.cpp =================================================================== --- clang/test/Frontend/rewrite-includes-macros.cpp +++ clang/test/Frontend/rewrite-includes-macros.cpp @@ -1,7 +1,8 @@ -// REQUIRES: system-windows -// RUN: %clang_cl /E -Xclang -frewrite-includes %s | %clang_cl /c -Xclang -verify /Tp - +// RUN: %clang_cl /E -Xclang -frewrite-includes -- %s | %clang_cl /c -Xclang -verify /Tp - // expected-no-diagnostics +// This test uses dos-style \r\n line endings. +// Make sure your editor doesn't rewrite them to unix-style \n line endings. int foo(); int bar(); #define HELLO \
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
