akhuang marked an inline comment as done. akhuang added inline comments.
================ Comment at: clang/include/clang/Basic/AttrDocs.td:1410 + For Windows targets, ``[[no_unique_address]]`` is ignored, but there is a + similar attribute spelled ``[[msvc::no_unique_address]]``. }]; ---------------- aaron.ballman wrote: > "similar" makes me wonder "so how is it different?" which the docs don't > answer. I think this could be stated as: > ``` > For Windows targets, ``[[no_unique_address]]`` is ignored; use > ``[[msvc::no_unique_address]]`` instead. > ``` > WDYT? yep, that sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
