artem added inline comments.

================
Comment at: clang/test/ubsan/TestCases/Misc/abs.cpp:1
+// REQUIRES: arch=x86_64
+//
----------------
MaskRay wrote:
> Did you mean compiler-rt/ instead of clang/?
> 
> `// REQUIRES: arch=x86_64` is legacy style.
> 
> New style uses `// REQUIRES: target={{x86_64.*}}`
> 
> Actually, this test should be generic and we should remove REQUIRES.
I think that Aaron has moved the file when committed to the main branch. 
Anyway, moved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156821/new/

https://reviews.llvm.org/D156821

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to