hans added inline comments.
================ Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' [-Woverriding-t-option] ---------------- dexonsmith wrote: > MaskRay wrote: > > dexonsmith wrote: > > > Why would we want to use the old name here? An alias seems strictly > > > better to me. > > Making `overriding-t-option` an alias for `overriding-option` would make > > `-Wno-overriding-t-option` applies to future overriding option diagnostics, > > which is exactly what I want to avoid. > > > I understand that you don't want `-t-` to apply to work on future overriding > option diagnostics, but I think the platform divergence you're adding here is > worse. > > Having a few Darwin-specific options use `-Woverriding-t-option` (and > everything else use `-Woverriding-option`) as the canonical spelling is hard > to reason about for maintainers, and for users. > > And might not users on other platforms have `-Woverriding-t-option` hardcoded > in build settings? (So @dblaikie's argument that we shouldn't arbitrarily > make things hard for users would apply to all options?) > > IMO, if we're not comfortable removing `-Woverriding-t-option` entirely, then > it should live on as an alias (easy to reason about), not as > canonical-in-special-cases (hard to reason about). > IMO, if we're not comfortable removing -Woverriding-t-option entirely, then > it should live on as an alias (easy to reason about), not as > canonical-in-special-cases (hard to reason about). +1 if we can't drop the old spelling, an alias seems like the best option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158301/new/ https://reviews.llvm.org/D158301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
