awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land.
LGTM, ta! ================ Comment at: clang/include/clang/Driver/Options.td:5314 NegFlag<SetTrue, [], [ClangOption, CC1Option, FlangOption], "Disable">, - PosFlag<SetFalse, [], [ClangOption], "Enable">, + PosFlag<SetFalse, [], [ClangOption, CC1Option, FlangOption], "Enable">, BothFlags<[], [ClangOption], " the integrated assembler">>; ---------------- Could you add a test? https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/fno-integrated-as.f90 I would probably rename that file as `integrated-as.f90` and test 3 variants: ``` ! RUN: <no flag> ! RUN: -fintegrated-as ! RUN: -fno-integrated-as ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158612/new/ https://reviews.llvm.org/D158612 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
