phosek added a comment.
After this change, all libc++ `clang_modules_include.gen.py` tests started
failing on our Linux builders:
Script:
--
: 'COMPILED WITH'; /b/s/w/ir/x/w/llvm_build/./bin/clang++
/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/algorithm.compile.pass.cpp
-pthread --target=aarch64-unknown-linux-gnu -nostdinc++ -I
/b/s/w/ir/x/w/llvm_build/include/c++/v1 -I
/b/s/w/ir/x/w/llvm_build/include/aarch64-unknown-linux-gnu/c++/v1 -I
/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support -std=c++26 -Werror -Wall
-Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template
-Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move
-Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier
-Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare
-Wunused-variable -Wunused-parameter -Wunreachable-code
-Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions
-Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete
-Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
-D_LIBCPP_ENABLE_EXPERIMENTAL -Werror=thread-safety -Wuser-defined-warnings
-fsyntax-only
: 'RUN: at line 2'; /b/s/w/ir/x/w/llvm_build/./bin/clang++
/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/algorithm.compile.pass.cpp
-pthread --target=aarch64-unknown-linux-gnu -nostdinc++ -I
/b/s/w/ir/x/w/llvm_build/include/c++/v1 -I
/b/s/w/ir/x/w/llvm_build/include/aarch64-unknown-linux-gnu/c++/v1 -I
/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support -std=c++26 -Werror -Wall
-Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template
-Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move
-Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier
-Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare
-Wunused-variable -Wunused-parameter -Wunreachable-code
-Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions
-Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete
-Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
-D_LIBCPP_ENABLE_EXPERIMENTAL -Werror=thread-safety -Wuser-defined-warnings
-fmodules -fcxx-modules
-fmodules-cache-path=/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/Output/algorithm.compile.pass.cpp.dir/t.tmp
-fsyntax-only
--
Exit Code: 1
Command Output (stdout):
--
$ ":" "COMPILED WITH"
$ "/b/s/w/ir/x/w/llvm_build/./bin/clang++"
"/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/algorithm.compile.pass.cpp"
"-pthread" "--target=aarch64-unknown-linux-gnu" "-nostdinc++" "-I"
"/b/s/w/ir/x/w/llvm_build/include/c++/v1" "-I"
"/b/s/w/ir/x/w/llvm_build/include/aarch64-unknown-linux-gnu/c++/v1" "-I"
"/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support" "-std=c++26" "-Werror"
"-Wall" "-Wctad-maybe-unsupported" "-Wextra" "-Wshadow" "-Wundef"
"-Wunused-template" "-Wno-unused-command-line-argument" "-Wno-attributes"
"-Wno-pessimizing-move" "-Wno-noexcept-type" "-Wno-atomic-alignment"
"-Wno-reserved-module-identifier" "-Wno-user-defined-literals"
"-Wno-tautological-compare" "-Wsign-compare" "-Wunused-variable"
"-Wunused-parameter" "-Wunreachable-code" "-Wno-unused-local-typedef"
"-Wno-local-type-template-args" "-Wno-c++11-extensions" "-Wno-unknown-pragmas"
"-Wno-pass-failed" "-Wno-mismatched-new-delete" "-Wno-redundant-move"
"-Wno-self-move" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER"
"-D_LIBCPP_ENABLE_EXPERIMENTAL" "-Werror=thread-safety"
"-Wuser-defined-warnings" "-fsyntax-only"
$ ":" "RUN: at line 2"
$ "/b/s/w/ir/x/w/llvm_build/./bin/clang++"
"/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/algorithm.compile.pass.cpp"
"-pthread" "--target=aarch64-unknown-linux-gnu" "-nostdinc++" "-I"
"/b/s/w/ir/x/w/llvm_build/include/c++/v1" "-I"
"/b/s/w/ir/x/w/llvm_build/include/aarch64-unknown-linux-gnu/c++/v1" "-I"
"/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support" "-std=c++26" "-Werror"
"-Wall" "-Wctad-maybe-unsupported" "-Wextra" "-Wshadow" "-Wundef"
"-Wunused-template" "-Wno-unused-command-line-argument" "-Wno-attributes"
"-Wno-pessimizing-move" "-Wno-noexcept-type" "-Wno-atomic-alignment"
"-Wno-reserved-module-identifier" "-Wno-user-defined-literals"
"-Wno-tautological-compare" "-Wsign-compare" "-Wunused-variable"
"-Wunused-parameter" "-Wunreachable-code" "-Wno-unused-local-typedef"
"-Wno-local-type-template-args" "-Wno-c++11-extensions" "-Wno-unknown-pragmas"
"-Wno-pass-failed" "-Wno-mismatched-new-delete" "-Wno-redundant-move"
"-Wno-self-move" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER"
"-D_LIBCPP_ENABLE_EXPERIMENTAL" "-Werror=thread-safety"
"-Wuser-defined-warnings" "-fmodules" "-fcxx-modules"
"-fmodules-cache-path=/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/Output/algorithm.compile.pass.cpp.dir/t.tmp"
"-fsyntax-only"
# command stderr:
clang++: clang/lib/Serialization/ASTReader.cpp:6515: void
clang::ASTReader::ReadPragmaDiagnosticMappings(DiagnosticsEngine &): Assertion
`IDAndOffset.second == 0 && "not a start location for a FileID"' failed.
While building module 'std_algorithm' imported from
/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/clang_modules_include.gen.py/algorithm.compile.pass.cpp:22:
While building module 'std_private_algorithm_adjacent_find' imported from
/b/s/w/ir/x/w/llvm_build/include/c++/v1/algorithm:1744:
While building module 'std_private_algorithm_iterator_operations' imported
from /b/s/w/ir/x/w/llvm_build/include/c++/v1/__algorithm/adjacent_find.h:14:
While building module 'std_private_algorithm_ranges_iterator_concept'
imported from
/b/s/w/ir/x/w/llvm_build/include/c++/v1/__algorithm/iterator_operations.h:13:
In file included from <module-includes>:1:
/b/s/w/ir/x/w/llvm_build/include/c++/v1/__algorithm/ranges_iterator_concept.h:13:10:
fatal error: could not build module 'std_private_iterator_concepts'
13 | #include <__iterator/concepts.h>
| ~~~~~~~~^
...
You can see the full output at
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8771862804321535569/test-results.
Would it be possible to revert this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158572/new/
https://reviews.llvm.org/D158572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
