danix800 added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:185-188 + CharUnits ElemSizeInChars = ASTCtx.getTypeSizeInChars(ElemType); + int64_t ElemSizeInBits = + (ElemSizeInChars.isZero() ? 1 : ElemSizeInChars.getQuantity()) * + ASTCtx.getCharWidth(); ---------------- steakhal wrote: > How can `ElemSizeInChar` be zero? > If it can be zero, could you demonstrate it by a test? Type in the wild does not have to be of non-zero size. MPI vendors might choose whatever implementation as they want. We are doing division so non-zero checking is necessary. https://reviews.llvm.org/D158707 added a few general testcases for zero-sized type processing on dynamic extent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158813/new/ https://reviews.llvm.org/D158813 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
