MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22
+ std::vector<StringRef> &Features) {
+ // Defaults.
+ bool EnableVPU = true;
----------------
Delete the comment. The code speaks itself.
```
if (Args.hasArg(options::OPT_mvevpu, options::OPT_mno_vevpu, true)
Features.push_back("+vpu");
```
================
Comment at: clang/test/Driver/ve-features.c:1
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mvevpu 2>&1 | FileCheck
%s -check-prefix=VEVPU
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mno-vevpu 2>&1 |
FileCheck %s -check-prefix=NO-VEVPU
----------------
kaz7 wrote:
> MaskRay wrote:
> > `-target ` has been deprecated since Clang 3.4. Use `--target=`
> I didn't know that. Thank you!
I think we typically spend just two RUN lines:
* one for the default
* one for `-mvevpu -mno-vevpu`
The additional coverage for having 3 RUN lines is probably not useful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
