aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317 + " with attribute 'no_caller_saved_registers'" + " or be compiled with '-mgeneral-regs-only'">, + InGroup<DiagGroup<"excessive-regsave">>; ---------------- pengfei wrote: > aaron.ballman wrote: > > Can you add a test case showing that `-mgeneral-regs-only` causes the > > diagnostic to be silenced? > It's a driver only option. I think we are not suggested to invoke %clang out > of driver testsing, right? Oh! I hadn't realized this was a driver-only option. Looking at it harder, I see that for x86, setting the driver option removes the x87, mmx, and sse features which we do have test coverage for. Thanks @pengfei for pointing that out, my request was already covered! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159068/new/ https://reviews.llvm.org/D159068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
