aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:710-716
+ "Shader model is required in target '%0' for DXIL generation">;
+def err_drv_dxil_unsupported_shader_model : Error<
+ "Shader model '%0' in target '%1' is invalid for DXIL generation">;
+def err_drv_dxil_missing_shader_stage : Error<
+ "Shader stage is required in target '%0' for DXIL generation">;
+def err_drv_dxil_unsupported_shader_stage : Error<
+ "Shader stage '%0' in target '%1' is invalid for DXIL generation">;
----------------
Hmmm in theory:
```
def err_drv_dxil_bad_shader_required_in_target : Error<
"shader %select{model|stage}0 is required in target '%1' for DXIL
generation">;
def err_drv_dxil_bad_shader_unsupported : Error<
"shader %select{model|stage}0 '%1' in target '%2' is invalid for DXIL
generation">;
```
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4054
+ if (T.getOSName().empty()) {
+ Diags.Report(diag::err_drv_dxil_missing_shader_model) << T.str();
+ } else if (!T.isShaderModelOS() || T.getOSVersion() == VersionTuple(0)) {
----------------
Idle question: can you pass `T` directly here? (I thought we had diagnostic
streaming support for `Triple` but I'm not spotting it with a quick look
through the source).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159103/new/
https://reviews.llvm.org/D159103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
