hokein added inline comments. ================ Comment at: clang-move/ClangMove.cpp:104 @@ +103,3 @@ + std::reverse(Namespaces.begin(), Namespaces.end()); + return Namespaces; +} ---------------- Aha, I see. I misused the `findLocationAfterToken` previously.
================ Comment at: clang-move/ClangMove.cpp:130 @@ +129,3 @@ + // Add #Includes. + std::string AllIncludesString; + // FIXME: Filter out the old_header.h and add header guard. ---------------- For anonymous namespace, `getNamespaces` just makes it an empty string. Apart from that, we have to deal with other exceptions, for instance: ``` namespace a { void A::f() {} } ``` What we want is namespace `a`, but `getQualifiedNameAsString` returns `a::A::f`. Thus, using `getQualifiedNameAsString` wouldn't simplify the code at the moment. https://reviews.llvm.org/D24243 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits