arsenm added inline comments.
================ Comment at: clang/lib/CodeGen/CGCall.cpp:2035 + + FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ",")); +} ---------------- do you need to guard against adding the empty attribute? I don't want to see "target-features"="" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://reviews.llvm.org/D159206 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits