nickdesaulniers added a comment. Mind adding tests for `%#X` and `%#o` as well, since you're changing the behavior of those, too?
I think it would also be good to have explicit tests for `%o` and `%b` where the value being printed was and was not `0`. IIUC, we cannot diagnose those (unless a literal value is being printed)? (Thanks for finding that one of the kernel cases was a false positive!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159138/new/ https://reviews.llvm.org/D159138 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
