PiotrZSL added a comment.

In D159045#4631650 <https://reviews.llvm.org/D159045#4631650>, @felix642 wrote:

> We can already disable those options if we don't define them in the config. 
> Adding the possibility to provide optional values seems redundant to me. Do 
> you see any reason why we would absolutely need to add this option to the 
> config if we want to disable it?

a) If you use config file inheritance, when one config file define it, and 
other that inherit it (or command line) want to disable such option.
b) When we use --dump-config then it will be printed anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159045/new/

https://reviews.llvm.org/D159045

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D159045:... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D15... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D15... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D15... Piotr Zegar via Phabricator via cfe-commits
    • [PATCH] D15... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D15... Piotr Zegar via Phabricator via cfe-commits
    • [PATCH] D15... Félix-Antoine Constantin via Phabricator via cfe-commits
    • [PATCH] D15... Piotr Zegar via Phabricator via cfe-commits

Reply via email to