MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:55
+ StringRef UseLinker = A ? A->getValue() : CLANG_DEFAULT_LINKER;
+ // FIXME: What about -fuse-ld=<path>?
+ return UseLinker == "bfd" || UseLinker == "gld";
----------------
`-fuse-ld=<path>` is deprecated by `--ld-path=`. So just drop this FIXME.
================
Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:84
+ // FIXME: Could also use /usr/bin/gld here.
+ return std::string("/usr/gnu/bin/ld");
+
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85309/new/
https://reviews.llvm.org/D85309
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
