sebpop added inline comments.

Comment at: clang/lib/CodeGen/CGCXX.cpp:137
@@ -136,1 +136,3 @@
+  // r254170: Disallow aliases to available_externally.
+  if (TargetLinkage == llvm::GlobalValue::AvailableExternallyLinkage)
Please remove the reference to r254170.
You may want to put a reference to a bug, or better, just describe in full why 
this is disabled.

Comment at: clang/lib/CodeGen/CGCXX.cpp:166
@@ -162,3 +165,3 @@
     // FIXME: An extern template instantiation will create functions with
     // linkage "AvailableExternally". In libc++, some classes also define
     // members with attribute "AlwaysInline" and expect no reference to
You may want to adjust this comment, now that the condition does not check for 
You can move part of the FIXME in the comment above.

cfe-commits mailing list

Reply via email to