iana marked 2 inline comments as done.
iana added inline comments.

================
Comment at: clang/lib/Headers/module.modulemap:269
+  explicit module wint_t {
+    header "__stddef_wint_t.h"
+    export *
----------------
Arguably this should be textual since stddef.h shouldn't own wint_t and it's 
just here for compatibility. Otherwise I think the ODR would force wchar.h to 
define need_wint and include stddef.h which is kind of weird?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159064/new/

https://reviews.llvm.org/D159064

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to