erichkeane added a comment.

In D159490#4643196 <https://reviews.llvm.org/D159490#4643196>, 
@giulianobelinassi wrote:

> In D159490#4643191 <https://reviews.llvm.org/D159490#4643191>, @fdeazeve 
> wrote:
>
>> I think this may have broken builds:
>>
>>   worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function 
>> definition is not allowed here
>>   static bool mustPrintOnLeftSide(const Attr *A) {
>>
>> Probably missing a `}`?
>
> No, there is just an extra switch statement that somehow got into the patch. 
> I will fix this in a second.

Yikes, what I get for committing and not building first :)  I believe 
@giulianobelinassi still doesn't have commit access, so I'll just fix it as 
review-after-commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159490/new/

https://reviews.llvm.org/D159490

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D159490... Giuliano Belinassi via Phabricator via cfe-commits
    • [PATCH] D1... Erich Keane via Phabricator via cfe-commits
    • [PATCH] D1... Erich Keane via Phabricator via cfe-commits
    • [PATCH] D1... Felipe de Azevedo Piovezan via Phabricator via cfe-commits
    • [PATCH] D1... Giuliano Belinassi via Phabricator via cfe-commits
    • [PATCH] D1... Erich Keane via Phabricator via cfe-commits
    • [PATCH] D1... Erich Keane via Phabricator via cfe-commits
    • [PATCH] D1... Felipe de Azevedo Piovezan via Phabricator via cfe-commits
    • [PATCH] D1... Giuliano Belinassi via Phabricator via cfe-commits

Reply via email to