nickdesaulniers added a subscriber: jyknight. nickdesaulniers added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:857 + if (IsDynamic) { + const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = + getLangOpts().getStrictFlexArraysLevel(); ---------------- aaron.ballman wrote: > We don't generally use top-level const on local variables. Do we explicitly document this in the style guide? This came up for me recently in a code review (cc @jyknight ). https://llvm.org/docs/CodingStandards.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits