v.g.vassilev added inline comments.
================ Comment at: clang/lib/Lex/Preprocessor.cpp:998 +std::vector<Token> Preprocessor::LexAll() { + std::vector<Token> toks; ---------------- Shouldn't we take the results as a `LexAll(std::vector<Token> &result)`? Perhaps we should rename this interface to `LexTokensUntilEOF`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits